Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature tls #32

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feature tls #32

wants to merge 10 commits into from

Conversation

behrendt38
Copy link

Added the ability for a tls tunnel to be opened when the object is added to the LDAP_SERVER setting.

Copy link
Member

@AnaelMobilia AnaelMobilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Please avoid unecessary line feed changes, it made your PR more difficult to review.
Additionnaly, please fix the URL on the setup.py file.

Regards,
Anael

@AnaelMobilia AnaelMobilia requested a review from povtux March 4, 2020 07:38
@behrendt38
Copy link
Author

URL restored to the correct repo, I wasn't sure on the proper edict (this is my first PR)
Apologies for those line feeds - VS-Code went a little overboard with auto-formatting a simple issue.
Thanks.

@behrendt38 behrendt38 requested a review from AnaelMobilia June 4, 2020 18:10
@AnaelMobilia AnaelMobilia removed their request for review June 10, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants