Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert long numbers to strings in response #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jwillinghalpern
Copy link
Collaborator

adds a new convertLongNumbersToStrings option to Filemaker.create(). Setting this to true converts long numbers such as those produced by FileMaker's Get(uuidNumber) and Random functions into strings rather than returning scientific notation with reduced precision.

This is the issue which prompted this feature: Luidog/node-red-contrib-filemaker#61. I haven't checked if fixing fms-api-client alone addresses the issue fully because I haven't tried this change with node red.

This part of the changed code felt a bit repetitive, not of a better way offhand though:

parseScriptResult(body, this.agent.convertLongNumbersToStrings)

@coveralls
Copy link

coveralls commented Feb 4, 2022

Coverage Status

Coverage increased (+0.006%) to 99.446% when pulling 9fbb585 on feature-longnumbers into 753bbda on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants