Test file uploads properly #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I'm right - compare https://github.com/Lullabot/MinkSelenium2Driver/actions/runs/10079992751/job/27868667932?pr=12 and https://github.com/Lullabot/MinkSelenium2Driver/actions/runs/10079992751/job/27868667689?pr=12 - 1 more fail on the latest firefox because of the changes to selenium but... the fail on standalone-firefox:4.1.2 is annoying - because obviously we can't have that... but this gives me an idea.... |
This reverts commit fb0385c.
|
Yay tests fail on the latest firefox as expected - but pass on everything else. This is due to Lullabot/php-webdriver#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should break until Lullabot/php-webdriver#15 lands... let's see how and if...