Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage default values for task parameters in deploy:git #244

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

plopesc
Copy link
Contributor

@plopesc plopesc commented Aug 12, 2023

@justafish I made some extra tests locally to improve error handling when parameters are not set.

In this way the expected error messages are shown when any of the required parameters are not set and the push value is interpreted as true when it is not set or is empty.

@plopesc plopesc requested a review from justafish August 12, 2023 07:52
@github-actions github-actions bot temporarily deployed to pantheon-pr-244 August 12, 2023 07:54 Destroyed
Base automatically changed from justafish/revert-deploy-git to main August 14, 2023 09:57
@github-actions github-actions bot temporarily deployed to pantheon-pr-244 August 14, 2023 10:00 Destroyed
@justafish
Copy link
Member

@plopesc looks like the tests are failing:

task: Failed to run task "deploy:git": exit status 1
[deploy:git] Please provide a commit message
Failed to execute command ./vendor/bin/task deploy:git directory=/tmp/release branch=pr-244 remote=ssh://codeserver.dev.22fcd7e9-8dd3-4bab-8fe0-7c856b1ee202@codeserver.dev.22fcd7e9-8dd3-4bab-8fe0-7c856b1ee202.drush.in:2222/~/repository.git message="0cbcee6372d06f17240c5a941887b7a12483470a" site=***.pr-244: exit status 201
Error: Process completed with exit code 1.

@github-actions github-actions bot temporarily deployed to pantheon-pr-244 August 15, 2023 10:34 Destroyed
@plopesc
Copy link
Contributor Author

plopesc commented Aug 15, 2023

@justafish I misspelled the word "mesage". Typo has been fixed.

Sorry for the inconvenience.

@github-actions github-actions bot temporarily deployed to pantheon-pr-244 August 15, 2023 11:21 Destroyed
@justafish
Copy link
Member

Thanks!

@justafish justafish merged commit c73d687 into main Aug 15, 2023
22 checks passed
@justafish justafish deleted the plopesc-patch-1 branch August 15, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants