Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #204: Add a task for interacting with Acquia #442

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

justafish
Copy link
Member

@justafish justafish commented Feb 22, 2024

relates: #204

@justafish justafish requested a review from YesCT February 22, 2024 10:33
@justafish
Copy link
Member Author

@YesCT would you be able to review this please as you've tested it elsewhere? 😁 🙏

Copy link

@isholgueras isholgueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works fine. The addition of specifying the database works well to me too.

tasks/acquia.yml Show resolved Hide resolved
tasks/acquia.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a deployment to pantheon-pr-442 March 5, 2024 17:17 In progress
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@beto-aveiga
Copy link
Collaborator

Hi @justafish,

Fetching the DB worked perfectly on my local. ✅
https://gist.github.com/beto-aveiga/e3877e0c599c2c25a2ff77f4afaa88a6

I'm unclear if you wanted me to test the other commands on this PR.
I think not all commands are easy to test, but I can try.

Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
justafish and others added 3 commits March 12, 2024 12:33
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
@justafish justafish changed the title Issue #204: Add a task for fetching a database from Acquia Issue #204: Add a task for interacting with Acquia Mar 28, 2024
@beto-aveiga
Copy link
Collaborator

I will test this.

@beto-aveiga
Copy link
Collaborator

beto-aveiga commented Nov 5, 2024

I'm stuck running composer install.
image

The issue is that the .github folder from Drainpipe is not being copied into the vendor/lullabot/drainipipe folder. Because that folder is not there, the actions that need to be copied when composer install runs are not found and fails.

I checked the commit fetched, which is the commit for that branch. I also checked that the README.md file on that PR was also updated in my vendor/lullabot/drainpipe directory. So, the code reference that the composer is fetching seems okay.

Why are a few folders omitted in vendor/lullabot/drainpipe? I don't know. I've done some research, but I can't find an answer.

@beto-aveiga beto-aveiga marked this pull request as ready for review November 5, 2024 22:22
@beto-aveiga beto-aveiga marked this pull request as draft November 5, 2024 22:29
Comment on lines +31 to +42
ddev config --auto
ddev start
ddev composer config extra.drupal-scaffold.gitignore true
ddev composer config --json extra.drupal-scaffold.allowed-packages \[\"lullabot/drainpipe\"]
ddev composer config --no-plugins allow-plugins.composer/installers true
ddev composer config --no-plugins allow-plugins.drupal/core-composer-scaffold true
ddev composer config --no-plugins allow-plugins.lullabot/drainpipe true
ddev composer config repositories.drainpipe --json '{"type": "path", "url": "drainpipe", "options": {"symlink": false}}'
ddev composer config extra.drainpipe.acquia --json '{"settings": true, "github": []}'
ddev composer config minimum-stability dev
ddev composer require lullabot/drainpipe --with-all-dependencies

Copy link
Collaborator

@beto-aveiga beto-aveiga Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using composer with --json is failing.
I'm not clear why.
I also tried multiple JSON configurations through composer without success.
I used this instead:

          ddev config --auto
          ddev start
          ddev composer config --json extra.drupal-scaffold.allowed-packages \[\"lullabot/drainpipe\"]
          ddev composer config --no-plugins allow-plugins.composer/installers true
          ddev composer config --no-plugins allow-plugins.drupal/core-composer-scaffold true
          ddev composer config --no-plugins allow-plugins.lullabot/drainpipe true
          jq '.extra.drainpipe.acquia.settings = true' composer.json > tmp.json && mv tmp.json composer.json
          ddev composer config minimum-stability dev
          ddev composer config repositories.drainpipe path drainpipe
          ddev composer config repositories.drainpipe.options.symlink false
          ddev composer require lullabot/drainpipe --with-all-dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beto-aveiga it's a ddev bug, will be fixed in the next release. We fixed it on main for #729 and you can do something similar here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client affected enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants