-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upgrading task in task #679
Conversation
cd test/fixtures/drainpipe-task-upgrade | ||
ddev start | ||
ddev composer install | ||
ddev task drupal:composer:development | ||
cp composer-upgraded.lock composer.lock | ||
ddev task drupal:composer:development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justafish I wonder if we should consider pulling in bats for testing, which is what ddev uses and is pretty nice for "shell as tests".
# Composer won't run updated plugin code until after its been | ||
# installed. Once we have two new releases after 3.11.0, that upgrade | ||
# task, we can remove this double call. | ||
ddev task drupal:composer:development || ddev task drupal:composer:development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever!
nice one 👍 |
This will fix this error when upgrading task originally reported at #164
drainpipe/src/BinaryInstaller.php
Line 253 in c293ed7
We need to add a
remove()
call before the copy, so the task binary can be replaced if it is still in use by a process.Here's a test that should hopefully fail and reproduce this issue: https://github.com/Lullabot/drainpipe/actions/runs/10692591483/job/29641292997