Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output php configurations without escaping them #625 #681

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Output php configurations without escaping them #625 #681

merged 6 commits into from
Sep 4, 2024

Conversation

beto-aveiga
Copy link
Collaborator

@beto-aveiga beto-aveiga commented Sep 4, 2024 •
edited
Loading

Fixes URLs with parameters for visual diffs in .tugboat/config.drainpipe-override.yml

@github-actions github-actions bot temporarily deployed to pantheon-pr-681 September 4, 2024 19:01 Destroyed
@beto-aveiga beto-aveiga linked an issue Sep 4, 2024 that may be closed by this pull request
Drainpipe not reading correctly the URLs for visual diffs #625
Closed
@github-actions github-actions bot temporarily deployed to pantheon-pr-681 September 4, 2024 19:32 Destroyed
@mrdavidburns mrdavidburns mentioned this pull request Sep 4, 2024
Closed
@github-actions github-actions bot temporarily deployed to pantheon-pr-681 September 4, 2024 19:41 Destroyed
@github-actions github-actions bot temporarily deployed to pantheon-pr-681 September 4, 2024 19:49 Destroyed
@github-actions github-actions bot temporarily deployed to pantheon-pr-681 September 4, 2024 19:57 Destroyed
@beto-aveiga beto-aveiga marked this pull request as ready for review September 4, 2024 19:58
@github-actions github-actions bot temporarily deployed to pantheon-pr-681 September 4, 2024 20:03 Destroyed
mrdavidburns
mrdavidburns approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mrdavidburns mrdavidburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed on a project that urls can be wrapped in single quotes.

@deviantintegral deviantintegral changed the title ISSUE-625: output php configurations without scaping them ISSUE-625: output php configurations without escaping them Sep 4, 2024
@deviantintegral deviantintegral changed the title ISSUE-625: output php configurations without escaping them Output php configurations without escaping them #625 Sep 4, 2024
deviantintegral
deviantintegral approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@deviantintegral deviantintegral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@mrdavidburns mrdavidburns merged commit 774bd6f into main Sep 4, 2024
53 checks passed
@mrdavidburns mrdavidburns deleted the issue-625-drainpipe-not-reading-correctly-the-urls-for-visual-diffs branch September 4, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdavidburns mrdavidburns mrdavidburns approved these changes

@deviantintegral deviantintegral deviantintegral approved these changes

@justafish justafish Awaiting requested review from justafish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drainpipe not reading correctly the URLs for visual diffs
3 participants
@beto-aveiga @deviantintegral @mrdavidburns