ISSUE-398: fail if there are red lines in the Status Report admin page #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it using other projects, and it worked. |
mrdavidburns
approved these changes
Sep 6, 2024
scaffold/Taskfile.yml
Outdated
| - | | ||
| [ $(drush core:requirements --severity=2 --format=tsv | wc -l) -lt 1 ] \ | ||
| && echo "🟢 Status Report page checked" \ | ||
| || false || echo "🔴 Status Report page check failed" |
There was a problem hiding this comment.
What's this || false for?
There was a problem hiding this comment.
You are right 🤔
I guess this wasn't needed...
Let me try without it.
deviantintegral
approved these changes
Sep 9, 2024
|
This is probably worth calling out specifically in the release notes since it could cause working builds to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check that fails if there are errors in the Status Report page.