Justafish/issue 204 acquia integration v3 #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beto-aveiga
changed the base branch from
main
to
justafish/issue-204-acquia-integration
…d deployment task instructions
Although this is not Drainpipe itself, the change makes sense. (suggested by Copilot) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
beto-aveiga
force-pushed
the
justafish/issue-204-acquia-integration--v3
branch
from
8601499 to
16e825a
Compare
…ssue-204-acquia-integration--v3
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Acquia integration by adding a deploy workflow and related actions along with documentation updates. Key changes include:
- A new Acquia workflow file and supporting GitHub Actions to deploy and manage Acquia environments.
- Additional composite actions for authentication, environment cloning, deployment status, and site updates.
- Updates to the README for integration instructions.
Reviewed Changes
Copilot reviewed 11 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/acquia.yml | Defines Acquia tasks including authentication and database fetching |
| scaffold/github/workflows/AcquiaDeploy.yml | Sets up the GitHub Actions workflow for deploying to Acquia |
| scaffold/github/actions/common/set-env/action.yml | Updates environment variable settings for downstream actions |
| scaffold/github/actions/common/deployment-status/action.yml | Provides a composite action for setting deployment status |
| scaffold/github/actions/common/deployment-create/action.yml | Creates a deployment and registers its ID with GitHub |
| scaffold/github/actions/acquia/update/action.yml | Runs site updates or installer based on input condition |
| scaffold/github/actions/acquia/push/action.yml | Pushes code to an Acquia environment with proper SSH and VCS checks |
| scaffold/github/actions/acquia/deploy/action.yml | Implements the core deployment to Acquia with setup, build, and post-deploy steps |
| scaffold/github/actions/acquia/clone-env/action.yml | Clones one Acquia environment to another |
| README.md | Documents the Acquia integration and required repository configuration |
| .github/workflows/TestAcquia.yml | Provides a test workflow for Acquia integration |
Files not reviewed (5)
- composer.json: Language not supported
- scaffold/acquia/.drainpipeignore: Language not supported
- scaffold/acquia/settings.acquia.php: Language not supported
- src/ScaffoldInstallerPlugin.php: Language not supported
- tests/local-test.sh: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
beto-aveiga
commented
Apr 17, 2025
| @@ -12,6 +12,15 @@ runs: | |||
| steps: | |||
| - run: | | |||
| echo "Setting Drainpipe environment variables:" | |||
| echo "DRAINPIPE_PR_NUMBER=$(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }')" >> $GITHUB_ENV | |||
| echo "DRAINPIPE_SHA=$(cat $GITHUB_EVENT_PATH | jq -r .pull_request.head.sha)" >> $GITHUB_ENV | |||
|
|
|||
There was a problem hiding this comment.
I will try to revert this one after/if all tests pass now.
There was a problem hiding this comment.
To revert the entire file.
There was a problem hiding this comment.
Reverted. I will try a deploy to DEV on a real site to see if deploying still works
There was a problem hiding this comment.
The deployment didn´t work when I restored the file.
The changes in this PR are needed.
beto-aveiga
force-pushed
the
justafish/issue-204-acquia-integration--v3
branch
from
31d708d to
6995581
Compare
This was referenced Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Deploy to Acquia Github workflow (with documentation).