Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ebook - Why Your CMS Project Will Fail #74

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

jazzdrive3
Copy link
Contributor

@jazzdrive3 jazzdrive3 commented Sep 16, 2024

Updated with images. Ready for final review.

Copy link
Collaborator

@sirkitree sirkitree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're still working on it, but thought I'd give some feedback early.

@@ -0,0 +1,11 @@
---
title: 'Five: Not knowing how to use the system'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as chapter-6

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

src/ebooks/why-your-cms-will-fail/chapters/chapter-2.md Outdated Show resolved Hide resolved
src/ebooks/why-your-cms-will-fail/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@sirkitree sirkitree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good. I have some pretty sweeping changes coming up in the branch I'm working on locally to address #72 but I think if you merge this I can then make those changes (mostly naming), and you can indicate which of these should be chapters in that issue.

If you want to indicate which ones are chapters in this PR, you can update the ones you want with front-matter, adding tags: [chapter]

@jazzdrive3
Copy link
Contributor Author

This should be fine as-is, with no changes. Everything works as a chapter for this one.

@sirkitree sirkitree merged commit 914d898 into main Sep 26, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants