Merge pull request #37 from Lumen5/improve-perf

Improve performance
Lumen5 · May 12, 2023 · a2a4d92 · a2a4d92
2 parents e23da4a + 35e2c4b
commit a2a4d92
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lumen5/framefusion",
-  "version": "0.0.19",
+  "version": "0.0.20",
   "type": "module",
   "scripts": {
     "docs": "typedoc framefusion.ts",

diff --git a/src/backends/beamcoder.ts b/src/backends/beamcoder.ts
@@ -311,12 +311,23 @@ export class BeamcoderExtractor extends BaseExtractor implements Extractor {
         if (this.#filteredFramesPacket.length > 0) {
             const closestFrame = this.#filteredFramesPacket
                 .flat()
-                .find(f => (f as Frame).pts <= targetPTS);
+                .find(f => (f as Frame).pts <= targetPTS) as Frame;
+
             if (closestFrame) {
+                const nextFrame = this.#filteredFramesPacket
+                    .flat()
+                    .find(f => (f as Frame).pts > closestFrame.pts) as Frame;
+
                 VERBOSE && console.log('returning previously filtered frame with pts', (closestFrame as Frame).pts);
                 closestFramePTS = (closestFrame as Frame).pts;
                 outputFrame = closestFrame;
                 this.#previousTargetPTS = targetPTS;
+
+                if (nextFrame && nextFrame.pts > targetPTS) {
+                    // We have a next frame, so we know the frame being displayed at targetPTS is the previous one,
+                    // which corresponds to outputFrame.
+                    return outputFrame;
+                }
             }
         }