Skip to content

Fixed cant execute vanilla commands after accidentally execute reload confirm` command #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

CoderFrish
Copy link

This pr aims to fixed cant execute vanilla commands after accidentally execute reload confirm` command.

Copy link
Contributor

@HaHaWTH HaHaWTH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there will be someone type /reload accidentally and then confirm it, server owners should acknowledge the potential risk when reloading the server.

@CoderFrish
Copy link
Author

I don't think there will be someone type /reload accidentally and then confirm it, server owners should acknowledge the potential risk when reloading the server.

There may be a handful of people who will ignore the warning and type in 'reload' and confirm....

@MrHua269
Copy link
Contributor

MrHua269 commented Jan 23, 2025

In case that folia is unspported to do reloading, I think the best way is to disable the reload command instead of continuing fixing that problematic method

You could see commit : 9553bc9

@MrHua269 MrHua269 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants