Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIL-410 #749

Merged
merged 8 commits into from
Oct 29, 2024
Merged

SKIL-410 #749

merged 8 commits into from
Oct 29, 2024

Conversation

rtkells
Copy link
Contributor

@rtkells rtkells commented Oct 29, 2024

TODOs Completed:

  • Added function in the backend to query the ratio of users who have completed an assessment
  • Created logic in the completed assessment routes to call this function if the assessment task parameter is given in the url
  • Created a genericResourceGET in AdminViewAssessmentStatus.js to get progress data, which is then passed as a property to the ViewAssessmentStatus.js component

Adham-Alammuri
Adham-Alammuri approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Adham-Alammuri Adham-Alammuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aparriaran
aparriaran approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@aparriaran aparriaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM!

@aparriaran
Copy link
Collaborator

@sah0017 I am going to merge this PR!

@aparriaran aparriaran merged commit a95a033 into master Oct 29, 2024
1 check passed
@aparriaran aparriaran deleted the SKIL-410 branch October 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparriaran aparriaran aparriaran approved these changes

@Adham-Alammuri Adham-Alammuri Adham-Alammuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtkells @aparriaran @Adham-Alammuri