Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIL-533 #755

Merged
merged 19 commits into from
Nov 7, 2024
Merged

SKIL-533 #755

merged 19 commits into from
Nov 7, 2024

Conversation

ebanderson3
Copy link
Contributor

TODOs completed:

  • Added parameter to genericResourceFetch that allows custom options
  • GET requests now allow optional "dest" parameter as an option that allows the frontend resource type and backend content type to match while allowing the final result to be put into its own variable.
  • Removed exceptional cases from utility.js that adjusted names of variables so that frontend and backend syntax matched
  • Updated all places where those exceptional cases were used to use the new options.dest syntax

Copy link
Collaborator

@aparriaran aparriaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM!

Copy link
Contributor

@jcallison1 jcallison1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sah0017 LGTM

@aparriaran
Copy link
Collaborator

@sah0017 I am going to merge this PR

@aparriaran aparriaran merged commit 3e8ca31 into master Nov 7, 2024
1 check passed
@aparriaran aparriaran deleted the SKIL-533 branch November 7, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants