Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsletter frontend and backend done : #542 done #550

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

VinayLodhi1712
Copy link
Contributor

newsletter frontend and backend done : #542 done
So this is the video first of all -
There is some network lag so website is loading slowly, so not mind that

20241025173843.mp4

So you have to keep mind this things -

  1. for newsletter option visible in footer is only visible to the admin. Because i think you don't want that everyone can send the newsletter to the user.

  2. you dont have any admin option so you have to set mongodb isAdmin value to true. See this image-

db 2

  1. this is newsletter schema for storing newsletter subscribing mail -
    database

  2. And you need to setup the nodemailer email id and password for sending the emails to the user for that you need smtp mail and password so which you can find its information and store in .env file -
    evn

Frontend is decent I think but i have work a lot in this from creating admin middleware to storing admin value and then admin context in frontend and then frontend for newsletter and apis in backend for it. So i have more focused on backend part . If you want any information then i can help you.

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
med-space ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 11:53am

@Luson045
Copy link
Owner

I think we had a component for mails, you can use that instead of writing separate code for mails. And there are some merge conflicts

@VinayLodhi1712
Copy link
Contributor Author

@Luson045 sir i have solved the merge conflict. Secondly, i have create other api because keep everything separate is a good thing it enhance code readability and this mail component has some separate body so i think it will be a good thing to keep it separately.

Also mentioning again the newsletter page is only allowed for admin role so you have to set your isAdmin to true in mongodb database for that emailid.

@VinayLodhi1712
Copy link
Contributor Author

also your footer is not looking with that background color and the footer section component is not visible so if you want to change it so i can work on it.

@Luson045 Luson045 merged commit 130bbb1 into Luson045:main Oct 28, 2024
2 checks passed
@Luson045
Copy link
Owner

Luson045 commented Oct 28, 2024

@VinayLodhi1712 okay. A lot of people are working on the footer issue, so I guess it's not needed as of now..

Instead you can work on this issue
image
there is some alignment and sizing issue with the navbar I guess, in android screen res. You can work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants