Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post 0.0.8 release #30

Merged
merged 2 commits into from
May 27, 2024
Merged

post 0.0.8 release #30

merged 2 commits into from
May 27, 2024

Conversation

cav71
Copy link
Contributor

@cav71 cav71 commented May 25, 2024

Description

Few issues emerged in post 0.0.8 release.

  1. the log format should include a time stamp
  2. utils.launch must standardize the exceptions returning the failed host info
  3. update sample2.py example code

new log format

The new log format (override-able on a per script base) will be:

2024-05-24 23:39:52,065 [I] luxos.cli.v1: py[3.11.9], luxos[/]
2024-05-24 23:39:52,066 [I] __main__: loading config from config.yaml
2024-05-24 23:39:52,067 [I] __main__: HELLO
2024-05-24 23:39:52,067 [I] luxos.cli.v1: task completed in 0.00s

launch exceptions standardize

All the luxos.utils.launch returned exceptions will be reraised as LuxosLaunchError carrying the host/port informations.

Merge request checklist

  • Added the appropriate bug, enhancement and/or breaking-change tags
  • My commits follow the How to Write a Git Commit Message Guide.
  • I have updated the CHANGELOG (yeah, last chance to do it).
  • My code passes all tests, linter and formatting checks:
    python make.pyz check
    python make.pyz tests

@cav71 cav71 added the enhancement New feature or request label May 25, 2024
@cav71 cav71 requested a review from GuzmanPintos May 25, 2024 03:26
@cav71 cav71 self-assigned this May 25, 2024
Copy link

linear bot commented May 25, 2024

LL-59 post 0.0.8 release

@cav71 cav71 force-pushed the antoniocavallo/ll-59-post-008-release branch from fd14bf9 to 38ae33f Compare May 27, 2024 14:30
@cav71 cav71 marked this pull request as ready for review May 27, 2024 14:39
@cav71 cav71 merged commit 22ab2a3 into main May 27, 2024
14 checks passed
@cav71 cav71 deleted the antoniocavallo/ll-59-post-008-release branch May 31, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants