Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luxos code refactoring (add async support) #7

Merged
merged 23 commits into from
Apr 4, 2024
Merged

luxos code refactoring (add async support) #7

merged 23 commits into from
Apr 4, 2024

Conversation

cav71
Copy link
Contributor

@cav71 cav71 commented Mar 30, 2024

This is the PR to refactor the code for luxos.py to support async and refactor code for release.

These are the requirements:

  • pip installable
  • Use of async over threading (new luxos --async flag)
  • Batch size control and wait between batches
  • Move COMMANDS into a separate file

These are the design improvements:

  • support for github workflows
  • code static and dynamic checks (ruff/mypy/coverage and unittests)
  • support for one-file script (pyz support)

@cav71 cav71 marked this pull request as ready for review March 30, 2024 16:32
@cschwartz1234 cschwartz1234 mentioned this pull request Apr 1, 2024
Closed
nicoalencar
nicoalencar reviewed Apr 2, 2024
View reviewed changes
Copy link

@nicoalencar nicoalencar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code! I think this adds a lot of maturity to those tools. Also theres a lot of good practices that we can replicate to other projects on the data team as well, so thanks for that!

Added a few comments but most of them are suggestions only :)

pyproject.toml Outdated Show resolved Hide resolved
src/luxos/asyncops.py Show resolved Hide resolved
src/luxos/exceptions.py Show resolved Hide resolved
src/luxos/scripts/async_luxos.py Outdated Show resolved Hide resolved
src/luxos/scripts/async_luxos.py Show resolved Hide resolved
cav71 added 4 commits April 2, 2024 19:44
@cav71
fix:
5957b9a 
 - update pyproject to support py >= 3.9
 - making use of max_threads to control cocurrency instead hard coding to 50
@cav71
update pyz files
1cc4b5c
@cav71
fix wrong assignment
0940aac
@cav71
update pyz files
d15e80e
@cav71 cav71 merged commit 884a790 into main Apr 4, 2024
14 checks passed
@cav71 cav71 deleted the pr/luxos-code-refactoring branch April 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoalencar nicoalencar nicoalencar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cav71 @nicoalencar