Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sharing #2564

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from
Open

Fix sharing #2564

wants to merge 1 commit into from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 18, 2024

On advice of @tinohager

  • add icon to indicate that user already has read access. no need to click anything else.
  • fix filtering of users in the selection when removing a user from the sharing.

@ildyria ildyria changed the base branch from master to v6 October 18, 2024 14:10
@ildyria ildyria added this to the 6.0.0 milestone Oct 18, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 18, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (a293683) to head (b50fb6b).

Additional details and impacted files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ildyria