Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: service name definition #149

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: service name definition #149

merged 2 commits into from
Dec 5, 2024

Conversation

JSahlberg42
Copy link
Contributor

Description

Service definition points to fullname without "-http" prefix.

Linked issue(s)

Relates #0000

Checklist

  • Unit tests updated
  • End user documentation updated

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@JSahlberg42
Update ingress.yaml
19beb6e 
Add missing "-http" to service name definition.

Signed-off-by: Jussi Sahlberg <59578056+JSahlberg42@users.noreply.github.com>
M0NsTeRRR
M0NsTeRRR requested changes Dec 5, 2024
View reviewed changes
Copy link
Owner

@M0NsTeRRR M0NsTeRRR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for your PR, can you upgrade the patch version number in Chart.yml and run helm-docs to regenerate the README.md ?
Regards,

@JSahlberg42
Copy link
Contributor Author

Version number upgraded to 1.0.1 and helm-docs ran.

@M0NsTeRRR M0NsTeRRR merged commit f3505f6 into M0NsTeRRR:main Dec 5, 2024
1 of 2 checks passed
@M0NsTeRRR
Copy link
Owner

Thanks for your contribution !

@JSahlberg42 JSahlberg42 deleted the patch-1 branch December 5, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0NsTeRRR M0NsTeRRR M0NsTeRRR requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSahlberg42 @M0NsTeRRR