Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGA Packing Patch #12

Merged
merged 5 commits into from
Oct 19, 2023
Merged

SGA Packing Patch #12

merged 5 commits into from
Oct 19, 2023

Conversation

ModernMAK
Copy link
Member

@ModernMAK ModernMAK commented Oct 18, 2023 •
edited
Loading

Additions / Fixes:

  • New Repack CLI entrypoint
  • Properly packs name buffer using '/' instead of '\'
  • Altered name repacking scheme to better match official archives.
    • This likely doesn't affect anything, but is nice when visually comparing archives.
  • Allow passing in class instance for Assembler & Disassembler
    • Callbacks were used previously, and should probably now be deprecated
    • Allows each version to manually specify how to assemble/disassemble their packed file system

@ModernMAK
Update CLI with Errors | Repack CLI | Allow Drive Names
8852811 
Test cases for issue 40 to ensure better error messages are printing

CLI has new repack debug function, accepts an SGA and repacks it, second argument is the optional new name. This should only be used for testing 'diffs' between an original SGA file and the tools packed version.

Drive names are now properly stored, I originally had them set to `` because they don't show up in the name block, but the name should be included somewhere to match expected behavior of relic's mod tools.
@ModernMAK
Flatten names as relic does
c4d002c 
Names are packed via collecting the active folder, then subfolders, then files.

Only improves the ability for diffing Repacked archives
@ModernMAK
Several hacks to allow DoW to read archives.
8357392 
I've successfully swapped two images, and repacked the archive so here's hoping.
@ModernMAK
Black | MyPy | PyLint | PyTest Fixes
f64e4bb
@ModernMAK
Update test_issue_40.py
ad5d98d 
Sequence type not found in collections (when I probably meant to use typing).
Moot point though, expected type should be iterable.
@ModernMAK ModernMAK changed the title Issue #40 and drive name hotifx SGA Packing Patch Oct 19, 2023
@ModernMAK ModernMAK marked this pull request as ready for review October 19, 2023 00:00
@ModernMAK ModernMAK merged commit fca6e51 into main Oct 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ModernMAK