Skip to content

Conversation

czarte
Copy link
Collaborator

@czarte czarte commented Sep 17, 2025

Note

Switches default chain to base-mainnet, makes --blockchain-service-url effectively required (with limited exceptions), updates default RatePack values, and aligns code/tests/docs accordingly.

  • Config/Defaults:
    • Set DEFAULT_CHAIN to Chain::BaseMainnet; update chain-specific directories, literals, and messages to base-mainnet.
    • Adjust error messages and expectations referencing chain name (e.g., web3 initializer panic, paths, descriptors).
  • CLI/Validation & Help:
    • Enforce --blockchain-service-url presence during unprivileged parsing (exceptions: zero-hop, --fake-public-key, --crash-point).
    • Expand BLOCKCHAIN_SERVICE_HELP and add public Base Mainnet endpoints; update tests for new text.
  • Rates:
    • Lower DEFAULT_RATE_PACK values; add high RatePack override in multinode test.
  • Blockchain/Web3:
    • Update expected tx hashes in web3 batch tests.
  • Tests/Fixtures:
    • Update numerous tests to pass --blockchain-service-url and to use base-mainnet paths/identifiers.
    • Align config dumper, setup reporter, bootstrapper, and node configurator tests with new defaults and requirements.

Written by Cursor Bugbot for commit 09b9baf. This will update automatically on new commits. Configure here.

…Configuration Error when blockchain-service-url is not provided, Help with links for public RPC endpoints
cursor[bot]

This comment was marked as outdated.

@czarte czarte changed the title Gh 685 GH-685 New Defaults and Blockchain service URL check Sep 17, 2025
@czarte czarte marked this pull request as draft September 18, 2025 15:44
@czarte czarte marked this pull request as ready for review September 19, 2025 12:27
cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@dnwiebe dnwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with review2 merged in.

@czarte czarte merged commit fb9718e into master Sep 30, 2025
7 checks passed
@czarte czarte deleted the GH-685 branch September 30, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants