-
Notifications
You must be signed in to change notification settings - Fork 32
GH-685 New Defaults and Blockchain service URL check #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Configuration Error when blockchain-service-url is not provided, Help with links for public RPC endpoints
czarte
commented
Sep 24, 2025
czarte
commented
Sep 24, 2025
node/src/blockchain/blockchain_interface/blockchain_interface_web3/utils.rs
Show resolved
Hide resolved
czarte
commented
Sep 24, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
node/src/node_configurator/unprivileged_parse_args_configuration.rs
Outdated
Show resolved
Hide resolved
dnwiebe
reviewed
Sep 29, 2025
node/src/node_configurator/unprivileged_parse_args_configuration.rs
Outdated
Show resolved
Hide resolved
dnwiebe
reviewed
Sep 29, 2025
node/src/node_configurator/unprivileged_parse_args_configuration.rs
Outdated
Show resolved
Hide resolved
dnwiebe
reviewed
Sep 29, 2025
node/src/node_configurator/unprivileged_parse_args_configuration.rs
Outdated
Show resolved
Hide resolved
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
reviewed
Sep 29, 2025
dnwiebe
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with review2 merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Switches default chain to base-mainnet, makes --blockchain-service-url effectively required (with limited exceptions), updates default RatePack values, and aligns code/tests/docs accordingly.
DEFAULT_CHAIN
toChain::BaseMainnet
; update chain-specific directories, literals, and messages tobase-mainnet
.--blockchain-service-url
presence during unprivileged parsing (exceptions:zero-hop
,--fake-public-key
,--crash-point
).BLOCKCHAIN_SERVICE_HELP
and add public Base Mainnet endpoints; update tests for new text.DEFAULT_RATE_PACK
values; add high RatePack override in multinode test.--blockchain-service-url
and to usebase-mainnet
paths/identifiers.Written by Cursor Bugbot for commit 09b9baf. This will update automatically on new commits. Configure here.