-
Notifications
You must be signed in to change notification settings - Fork 32
GH-818 Chunked Responses Review 1 #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dnwiebe
wants to merge
23
commits into
master
Choose a base branch
from
GH-818-StreamKey
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
multinode_integration_tests/tests/connection_termination_test.rs
Outdated
Show resolved
Hide resolved
dnwiebe
commented
Oct 1, 2025
multinode_integration_tests/tests/connection_termination_test.rs
Outdated
Show resolved
Hide resolved
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
dnwiebe
commented
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resume at proxy_server.rs:3258 green
dnwiebe
commented
Oct 2, 2025
dnwiebe
commented
Oct 11, 2025
czarte
reviewed
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors routing/return-route handling by embedding IDs in
Route, consolidating per-stream state inProxyServer, simplifying APIs (no separate return-route messages), and updating neighborhood/route structures, utilities, and tests accordingly.Route(set_return_route_id,return_route_id); remove separate ID passing.ExpectedServices::RoundTripno longer carries an ID; addhostname_opttoRouteQueryResponse.AddReturnRouteMessage; eliminate related plumbing.StreamInfomap to tracktunneled_host, DNS-retry, route, protocol, TTL; generate per-request return-route IDs; retire old maps.ExpectedServicehelpers (accessors for keys/wallets/rates).TtlHashMap: add retire-closure andremove; timing/cleanup changes.StreamKey::make_meaningless_stream_keynow random.HttpPacketFramer.return_route_idparameters, addingstream_key, and aligning with new APIs and behaviors..gitignoretweak.Written by Cursor Bugbot for commit 3798177. This will update automatically on new commits. Configure here.