Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugin TimeQuery #402

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

Mooling0602
Copy link
Contributor

该插件方便玩家在服务器内查询现实和游戏内的时间,由于是初始版本,尚未完成查询游戏内时间部分。

Copy link

Thanks for your contribution! 🎉
Please be patient before we done checking. If you've added or modified plugins, a brief report will be generated below.
Have a nice day!

# 合并前检查单(供仓库维护者参考)
- *插件适合提交;
- 提交者有权提交;
- 所提交信息完整有效;
- 插件分类正确,名称、介绍和说明符合要求。
详见贡献指南

@github-actions github-actions bot added the plugins Plugin modifications label Sep 18, 2024
Copy link

Last updated at: 2024-09-19 00:31:53 (UTC+8)
Add label recheck to regenerate manually

Plugin Validation Report

time_query

Info Value Valid
URL Mooling0602/TimeQuery-MCDR@main
Labels Information
Introduction en_us zh_cn
Meta mcdreforged.plugin.json
Latest Release 0.0.1
Meta Value
Name TimeQuery
Version 0.0.1
Authors Mooling0602
Description en_us Query the time in real time and in the game.
zh_cn 快速查询现实和游戏内的时间,并以24小时制显示。

@AnzhiZhang
Copy link
Member

相似插件 https://mcdreforged.com/en/plugin/daytime

@AnzhiZhang AnzhiZhang merged commit c8790f9 into MCDReforged:master Sep 19, 2024
1 check passed
Copy link

Well done! 🎉

Your pull request has been successfully merged.

We appreciate your hard work and valuable input. If you have any further questions or need additional changes, feel free to reach out.

Happy coding!

@alex3236
Copy link
Contributor

不是很理解,写这么个抽象玩意,查询游戏时间功能都没实现,为什么不直接 fork daytime 改改自己用,而是发个 0.0.1 往插件库传

@alex3236
Copy link
Contributor

另,放着内置库不用用第三方库,且未正确声明

https://github.com/MCDReforged/PluginCatalogue/blob/master/CONTRIBUTING_cn.md#前置工作要注意

@Mooling0602
Copy link
Contributor Author

Mooling0602 commented Sep 19, 2024 via email

@Mooling0602
Copy link
Contributor Author

不是很理解,写这么个抽象玩意,查询游戏时间功能都没实现,为什么不直接 fork daytime 改改自己用,而是发个 0.0.1 往插件库传

我写这个的主要目的不是为了查询游戏内时间,而是直接查询北京时间,已在插件readme中说明
并且我也指出如果只需要查询游戏时间可以直接去使用daytime,因此本插件与daytime并没有太大关联

@alex3236
Copy link
Contributor

我写这个的主要目的不是为了查询游戏内时间,而是直接查询北京时间,已在插件readme中说明
并且我也指出如果只需要查询游戏时间可以直接去使用daytime,因此本插件与daytime并没有太大关联

我的意思是,你完全可以给 daytime 加上查 utc+8 的功能,而不是单独写一个然后标“以后会实现游戏时间查询”

其实我很想吐槽的,这种功能完全是 minihud 这种 mod 该做的事,而且必然比 mcdr 完成的好得多…写这种怪东西不如建议全服使用 mod 呢(包括 daytime 也是)

以上非入库意见,仅代表我个人吐槽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins Plugin modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants