Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for sodium 0.6.0 #246

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

Bekfastbek
Copy link

No description provided.

@Bekfastbek Bekfastbek marked this pull request as draft September 7, 2024 23:58
@Bekfastbek
Copy link
Author

Bekfastbek commented Sep 7, 2024

i just started working on it i found that it has issues with lithium i will check why later and also i am new to java so it will take me a bit to do things

@flerouwu
Copy link

flerouwu commented Oct 3, 2024

Howdy @Bekfastbek! You still working on this PR? If not, I'd be happy to get around to looking into the issue and seeing if I can help get Nvidium updated with the beta versions of Sodium.

@Bekfastbek
Copy link
Author

Hi @flerouwu the thing is that nvidium is working out of the box by just changing supported sodium versions but i was looking into lithium and i found that sodium is interfering with lithium and not nvidium so i started to focus on there a bit

@KarmaMarazu
Copy link
Collaborator

Hi @flerouwu the thing is that nvidium is working out of the box by just changing supported sodium versions

Last i checked it doesnt crash but also doesnt work/add anything

@Bekfastbek
Copy link
Author

Hi @flerouwu the thing is that nvidium is working out of the box by just changing supported sodium versions

Last i checked it doesnt crash but also doesnt work/add anything

I can check why it is happening after I am done with classes but I was unaware about that issue since it was working for me as I might be using an older beta of sodium 0.6 (didnt get to update since I was busy for the past month) and I specified that specific version of sodium just to test it so hopefully its just an easy 1 line fix and not a separate issue

@Bekfastbek
Copy link
Author

i found that nvidium loads up and is shown in loaded mods on client but it fails to create a config file and does not show up in settings just like you said so i might try more things to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants