-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a new release to have a py3.12 compatible package #62
Comments
pinging @orbeckst here as the person in the know for this package |
Deployment workflow would be great (issue #57), not saying that this your job. |
With all the latest updates to CI, I feel ready for 0.9.0! |
Holding until PR #68 is merged. |
Created tag release-0.9.0... |
The workflow is not valid. .github/workflows/deploy.yaml (Line: 18, Col: 9): Unexpected end of expression: ')'. Located at position 120 within expression: github.repository == 'MDAnalysis/MDAnalysisData' && ... need to fix |
Need to add packages to the test suite. |
(When do I learn to use "rc" release tags when testing anything with deployment... sigh.) |
Progress currently blocked by #72 . |
(Note to self: test deployment with release-0.9.0-rc1, when all good, move the release-0.9.0 tag to HEAD and force-push tags, ignore resulting test.pypi failure, and hope that the upload to pypi works) |
WIth PR #73 merged we need to check that #72 is really fixed.
|
0.9.0-rc1 won't work because pypi will always pick up a full release over an rc one and it's alreayd on testpypi. |
You are right. However, in this particular case, the test was still a success: It uploaded 0.9.0-rc1 (which had already worked before), and it then successfully downloaded 0.9.0 and ran the tests — and it was really the latter that needed testing. I'm fine with counting this as a success and moving on to releasing 0.9.0. |
Created the GitHub release https://github.com/MDAnalysis/MDAnalysisData/releases/tag/release-0.9.0 |
Upload to https://pypi.org/project/MDAnalysisData/0.9.0/ was successful. (Testing in the action did not work as intended because it pulled 0.8.1.). Locally 0.9.0 works. conda-forge is in progress with PR conda-forge/mdanalysisdata-feedstock#8 |
conda-forge is done. |
With #61 merged, we should try to make a new release.
I'm not sure what is the status of MDAnalysisData, we could stick on a deployment workflow or just make a bog standard release as-is.
The text was updated successfully, but these errors were encountered: