Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new release to have a py3.12 compatible package #62

Closed
IAlibay opened this issue Oct 29, 2023 · 17 comments
Closed

Make a new release to have a py3.12 compatible package #62

IAlibay opened this issue Oct 29, 2023 · 17 comments
Assignees

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 29, 2023

With #61 merged, we should try to make a new release.

I'm not sure what is the status of MDAnalysisData, we could stick on a deployment workflow or just make a bog standard release as-is.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

pinging @orbeckst here as the person in the know for this package

@orbeckst orbeckst self-assigned this Oct 29, 2023
@orbeckst
Copy link
Member

Deployment workflow would be great (issue #57), not saying that this your job.

@orbeckst
Copy link
Member

With all the latest updates to CI, I feel ready for 0.9.0!

@orbeckst
Copy link
Member

Holding until PR #68 is merged.

@orbeckst
Copy link
Member

Created tag release-0.9.0...

@orbeckst
Copy link
Member

@orbeckst
Copy link
Member

The workflow is not valid. .github/workflows/deploy.yaml (Line: 18, Col: 9): Unexpected end of expression: ')'. Located at position 120 within expression: github.repository == 'MDAnalysis/MDAnalysisData' &&
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')

... need to fix

This was referenced Oct 30, 2023
@orbeckst
Copy link
Member

  • ✅ TestPypi deployment itself worked https://github.com/MDAnalysis/MDAnalysisData/actions/runs/6698031942/job/18199197552
  • 🔴 Test FAILED
    ==================================== ERRORS ====================================
    _________________ ERROR at setup of test_fetch_remote_sha_fail _________________
    file /home/runner/work/MDAnalysisData/MDAnalysisData/MDAnalysisData/tests/test_base.py, line   107
      def test_fetch_remote_sha_fail(remote_topology, mocker):
    E       fixture 'mocker' not found
    >       available fixtures: bunch, cache, capfd, capfdbinary, caplog, capsys, capsysbinary,   doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, remote_topology, some_text, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
    >       use 'pytest --fixtures [testpath]' for help on them.
    

Need to add packages to the test suite.

@orbeckst
Copy link
Member

(When do I learn to use "rc" release tags when testing anything with deployment... sigh.)

@orbeckst
Copy link
Member

Progress currently blocked by #72 .

@orbeckst
Copy link
Member

(Note to self: test deployment with release-0.9.0-rc1, when all good, move the release-0.9.0 tag to HEAD and force-push tags, ignore resulting test.pypi failure, and hope that the upload to pypi works)

@orbeckst
Copy link
Member

orbeckst commented Oct 31, 2023

WIth PR #73 merged we need to check that #72 is really fixed.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 31, 2023

0.9.0-rc1 won't work because pypi will always pick up a full release over an rc one and it's alreayd on testpypi.
You'll have to do 0.9.1-rc1 or alpha.

@orbeckst
Copy link
Member

orbeckst commented Oct 31, 2023

You are right. However, in this particular case, the test was still a success: It uploaded 0.9.0-rc1 (which had already worked before), and it then successfully downloaded 0.9.0 and ran the tests — and it was really the latter that needed testing.

I'm fine with counting this as a success and moving on to releasing 0.9.0.

@orbeckst
Copy link
Member

Created the GitHub release https://github.com/MDAnalysis/MDAnalysisData/releases/tag/release-0.9.0

@orbeckst
Copy link
Member

Upload to https://pypi.org/project/MDAnalysisData/0.9.0/ was successful. (Testing in the action did not work as intended because it pulled 0.8.1.). Locally 0.9.0 works.

conda-forge is in progress with PR conda-forge/mdanalysisdata-feedstock#8

@orbeckst
Copy link
Member

conda-forge is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants