Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syntax error in deploy.yaml #71

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix syntax error in deploy.yaml #71

merged 2 commits into from
Oct 30, 2023

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst requested a review from IAlibay October 30, 2023 19:48
@orbeckst orbeckst self-assigned this Oct 30, 2023
@orbeckst orbeckst mentioned this pull request Oct 30, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cde331) 56.06% compared to head (409e0e9) 56.06%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files          12       12           
  Lines         371      371           
  Branches       51       51           
=======================================
  Hits          208      208           
  Misses        160      160           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orbeckst orbeckst linked an issue Oct 30, 2023 that may be closed by this pull request
Add codecov token to CI #70
Closed
IAlibay
IAlibay approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is quite the annoying typo 🙀 - lgtm!

@orbeckst
Copy link
Member Author

Hope it works.

I copied from GridDataFormats deploy so I put up a PR there to fix, too.

@orbeckst orbeckst merged commit f8c9a1a into master Oct 30, 2023
11 checks passed
@orbeckst orbeckst deleted the fix-deploy branch October 30, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay approved these changes

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add codecov token to CI
2 participants
@orbeckst @IAlibay