-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tests #76
update tests #76
Conversation
The YiiP test failed locally for me. I adjusted the reference number of characters in the DESCR file (same as with wc) but because these tests are NOT run in CI, I am not 100% sure if this is correct or a local issue. I added comments to test_datasets.py about limitations and how to execute locally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 56.06% 56.18% +0.11%
==========================================
Files 12 12
Lines 371 372 +1
Branches 51 51
==========================================
+ Hits 208 209 +1
Misses 160 160
Partials 3 3
☔ View full report in Codecov by Sentry. |
Only works for Python 3.12, at least the way I wrote it. Failures like
|
(I don't have more time to work on this right now. Help is welcome!) |
I've opened PR #78 into this PR which has the right fix, I'm not 100% sure the missing |
Hello @orbeckst! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
update deprecacted pckg_resources use (fix update deprecated use of pkg_resources #75 )
potential reference value fix
fix reference DESCR length for YiiP test
The YiiP test failed locally for me. I adjusted the reference number of characters in the
DESCR file (same as with wc) but because these tests are NOT run in CI, I am not 100%
sure if this is correct or a local issue.
I added comments to test_datasets.py about limitations and how to execute locally.