Add level option to setup_logging
#116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 85.56% 85.94% +0.37%
==========================================
Files 8 8
Lines 568 569 +1
Branches 119 120 +1
==========================================
+ Hits 486 489 +3
+ Misses 67 66 -1
+ Partials 15 14 -1 ☔ View full report in Codecov by Sentry. |
hejamu
reviewed
Mar 20, 2024
PicoCentauri
force-pushed
the
logger-level
branch
from
a700e77
to
a1a5506
Compare
|
Hello @PicoCentauri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-04-03 11:26:59 UTC |
PicoCentauri
commented
Mar 27, 2024
hejamu
approved these changes
Apr 3, 2024
PicoCentauri
pushed a commit
that referenced
this pull request
Apr 3, 2024
Add `level` option to `setup_logging ` (#116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Boolean
debugoption insetup_loggingby more flexible integerlevelparameter. This allows downstream packages to use this function in a better way.