Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement drift correction #3

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Conversation

Balint817
Copy link
Contributor

Makes cinema mod automatically correct drift, making the background stay in sync and letting charters to get a bit more creative

@ALLMarvelous ALLMarvelous self-assigned this Apr 2, 2024
@ALLMarvelous
Copy link
Collaborator

You're gonna have to explain to me what drift is because I'm not even sure what that means

@Balint817
Copy link
Contributor Author

Balint817 commented Apr 3, 2024

Drift is how much it is out of sync.
Since no measures were taken to prevent it going out of sync, it isn't very surprising that it did.
Additionally, since the newest update, the game also occasionally freezes, potentially causing desyncs measurable in seconds.
If you're interested in how often Cinema desyncs, make a debug build, I added debug messages while testing it.

@ALLMarvelous
Copy link
Collaborator

I'll give this PR some testing

@ALLMarvelous
Copy link
Collaborator

Thanks for this PR. The initial purpose of Cinema was just to have a music video play in the background, so this sort of stuff never initially mattered to me. However, this change can make it easier for people to make gimmick charts with Cinema, so I will be merging this.

Gonna make a few changes to keep the new class in the style of the project and then I'll merge. Thanks again for taking the time.

Copy link
Collaborator

@ALLMarvelous ALLMarvelous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change

@ALLMarvelous ALLMarvelous merged commit 3be85de into MDMods:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants