Skip to content

Feature/reintroduce flux limiter#772

Merged
Debraheem merged 14 commits intomainfrom
feature/reintroduce_flux_limiter
Mar 8, 2025
Merged

Feature/reintroduce flux limiter#772
Debraheem merged 14 commits intomainfrom
feature/reintroduce_flux_limiter

Conversation

@Debraheem
Copy link
Member

see #771. where @JRGarza has reimplemented a flux limiter for use with the dPrad_dm form of the T-gradient equation.

Resolves #769
Related to #625

JRGarza and others added 3 commits January 27, 2025 13:30
…ofile columns flux_limit_lambda and flux_limit_R (ported from r9793)
Porting the flux-limiter prescription from r9793 to the latest MESA version
@Debraheem Debraheem added the enhancement New feature or request label Jan 27, 2025
@Debraheem
Copy link
Member Author

Let's make sure there are no floating point errors associated with this. I don't know if we need to save any star information in the photos, but let's see what happens to :
ppisn
ccsn_IIp
hse_riemann
pisn

all use dPrad_dm form of the T-gradient eqn.

https://testhub.mesastar.org/feature%2Freintroduce_flux_limiter/commits/9f8a91c.

I'll add a fpe check as well.

@pmocz pmocz self-requested a review February 12, 2025 18:56
! ::

use_dPrad_dm_form_of_T_gradient_eqn = .false.
use_flux_limiting_with_dPrad_dm_form = .true.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder: switch back to false before merge

@Debraheem
Copy link
Member Author

This pr needs testing and a changelog before it can be merged.

!lum_rad_div_L_Edd_sub_fourPrad_div_PchiT ! density increases outward if this is > 0
! see Joss, Salpeter, and Ostriker, "Critical Luminosity", ApJ 181:429-438, 1973.
Frad_div_cUrad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add :
flux_limit_lambda
flux_limit_R

@warrickball
Copy link
Contributor

I put bluebear_ifort on this on got a failure on ppisn: test results

The rsp_gyre and rsp_save_and_load_file errors look like some ifort thing I'll have to debug some time but I think they can be ignored for now.

@Debraheem Debraheem merged commit d52ea1e into main Mar 8, 2025
4 checks passed
@VincentVanlaer VincentVanlaer deleted the feature/reintroduce_flux_limiter branch February 12, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flux-limited diffusion radiation hydrodynamics in later versions of MESA

4 participants