Skip to content

Implement Config Refresh on Middleware Side #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psmit03 merged 1 commit into from
Apr 11, 2025
Merged

Implement Config Refresh on Middleware Side #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/endpoints/restapi/restapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ func putYamlHandler(w http.ResponseWriter, r *http.Request) {
return
}

config.LoadYaml()
Copy link

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to config.LoadYaml() does not handle potential errors. Consider capturing and handling errors from config.LoadYaml() (e.g., logging the error and returning an appropriate HTTP error status) to ensure that configuration loading failures are not silently ignored.

Copilot uses AI. Check for mistakes.
w.WriteHeader(http.StatusOK)

_, err = w.Write([]byte("YAML updated"))
Expand Down