-
Notifications
You must be signed in to change notification settings - Fork 68
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
f5744a8
commit 7e6ea2a
Showing
4 changed files
with
48 additions
and
36 deletions.
There are no files selected for viewing
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
## Description | ||
|
||
Please include a summary of the changes and the related issue(s) if they exist. | ||
Please also include relevant motivation and context. | ||
|
||
Fixes #(issue) [optional] | ||
|
||
### Type of change | ||
|
||
Please delete options that are not relevant. | ||
|
||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Something else | ||
|
||
## How Has This Been Tested? | ||
|
||
Please describe the tests that you ran to verify your changes. | ||
Provide instructions so we can reproduce. | ||
Please also list any relevant details for your test configuration | ||
|
||
- [ ] Test A | ||
- [ ] Test B | ||
|
||
**Test Configuration**: | ||
|
||
* What computers and compilers did you use to test this: | ||
|
||
## Checklist: | ||
|
||
- [ ] I have added comments for new code | ||
- [ ] I added Doxygen docstrings to new code | ||
- [ ] I have made corresponding changes to the documentation (`docs/`) | ||
- [ ] I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected | ||
- [ ] I have added example cases in `examples/` that demonstrate my new feature performing as expected | ||
- [ ] New and existing tests pass locally with my changes, including with GPU capability enabled and disabled | ||
- [ ] This PR does not introduce any repeated code (it follows the [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) principle) | ||
- [ ] I cannot think of a way to condense this code and reduce any introduced additional line count | ||
|
||
### If your code changes any code source files (anything in `src/`) | ||
|
||
To make sure the code is performing as expected on GPU devices, I have: | ||
- [ ] Checked that the code compiles using NVHPC compilers | ||
- [ ] Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results) | ||
- [ ] Enclosed the new feature via `nvtx` ranges so that they can be identified in profiles | ||
- [ ] Ran a Nsight Systems profile using `./mfc.sh run XXXX --gpu -t simulation --nsys`, and have attached the output file (`.nsys-rep`) and plain text results to this PR | ||
- [ ] Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters