Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited m_reimann_solvers.fpp #215

Closed
wants to merge 1 commit into from
Closed

Edited m_reimann_solvers.fpp #215

wants to merge 1 commit into from

Conversation

KrishnaSr71
Copy link

I checked with the CI, and everything seems to be working. I condensed 88 lines, but I'm thinking I can condense about 40-50 more, because there's still a lot of duplicate code with maybe one variable name different.

Also, I think I pull-requested my ci.yml file. Is it possible for you to ignore that? I couldn't figure out how to just PR the m_riemann_solvers.fpp file.

Thanks!

Copy link
Member

@henryleberre henryleberre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, @KrishnaSr71 to MFC! Your first commit has hash 91d199255357fbe06564a493844b703e850b1b25. Thus, you can

$ git reset --soft 91d199255357fbe06564a493844b703e850b1b25~1

to un-commit all of your changes, reverting to the commit prior to your first (using ~1 meaning the commit prior), while keeping your aggregate changes staged (but not committed). If you run git status you will see them as such. git log will show HEAD pointing to an upstream commit.

To discard your modifications to .github/workflows/ci.yml, you can unstage it:

$ git restore --staged .github/workflows/ci.yml

Now, only src/simulation/m_riemann_solvers.fpp is staged. You can

$ git commit
$ git push -f

to (force-)update your master branch to only contain a single commit that contains all of your changes to src/simulation/m_riemann_solvers.fpp. This will make your intermediate commits disappear.

@sbryngelson
Copy link
Member

@KrishnaSr71 please add back the the self-hosted runners at the bottom of the CI to see if it passes on GPUs.

@sbryngelson
Copy link
Member

@KrishnaSr71 GPU face failed -- I would look into that. The Intel cases are failing but this is expected at the moment.

@KrishnaSr71
Copy link
Author

Got it.

@KrishnaSr71 KrishnaSr71 closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants