goldenfile metadata generation #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henryleberre requesting your review on this |
|
@sbryngelson I made a few edits to use CMake to obtain compiler information since using environment variables can unreliable. Let me know what you think. You can try regenerating the golden files. |
henryleberre
force-pushed
the
golden-meta
branch
from
b2ff2a5 to
dd2af8a
Compare
henryleberre
force-pushed
the
golden-meta
branch
from
dd2af8a to
e19219e
Compare
|
@henryleberre I was thinking we would include the |
|
@henryleberre if we don't include, then I need to delete the metadata files I already added to the PR. If we do include, then I need to update them. |
|
@sbryngelson I agree, we should include them. I just didn't re-generate them because I thought you would like to control how the new golden files were generated. |
sbryngelson
changed the title
JRChreim
pushed a commit
to JRChreim/MFC-JRChreim
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Henry LE BERRE <hberre3@gatech.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194