Improve count with intent to add to CI

[sbryngelson]

Improve ./mfc.sh count with intent to add to CI. Removes comment lines from count but includes openacc directives.

[sbryngelson]

Really want this to print the line count different between master and current.

Example https://github.com/tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

[henryleberre]

Really want this to print the line count different between master and current.

Example https://github.com/tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

[sbryngelson]

Really want this to print the line count different between master and current.
Example tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

I would like to know how many lines are being added or subtracted via a PR. I see some PRs where it's not immediately clear that a refactor actually reduces line count. The GitHub PR linecount diff includes all sorts of things that we don't care about.

[henryleberre]

Really want this to print the line count different between master and current.
Example tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

I would like to know how many lines are being added or subtracted via a PR. I see some PRs where it's not immediately clear that a refactor actually reduces line count. The GitHub PR linecount diff includes all sorts of things that we don't care about.

I see. For the specific case where you make a code-only refactor, you can subtract the + and - lines as shown on the PR's Github page since when you only modify a line, it counts as both a deletion and an addition. I just realized that things like adding (not changing) golden files do skew results, although they don't have many lines.

[sbryngelson]

Really want this to print the line count different between master and current.
Example tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

I would like to know how many lines are being added or subtracted via a PR. I see some PRs where it's not immediately clear that a refactor actually reduces line count. The GitHub PR linecount diff includes all sorts of things that we don't care about.

I see. For the specific case where you make a code-only refactor, you can subtract the + and - lines as shown on the PR's Github page since when you only modify a line, it counts as both a deletion and an addition. I just realized that things like adding (not changing) golden files do skew results, although they don't have many lines.

Yes this mostly does the job. Though I figure the CI mechanisms used for this would also be useful for other presumably more important things.

[sbryngelson]

@henryleberre I think this is the best this PR is going to get without more serious effort. The commit-bot is a no-go as you noticed. I was thinking that one could add an argument to ./mfc.sh count that allows a diff between two versions of MFC/src/* but this seems like more work/tricks than I can muster at the moment (I don't quite understand how it's going through and making those nice line count tables to begin with).