Fix Benchmark & Add Monopole Checks & Add Monopole Tests #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
viscous_weno5_sgb_mono
case file.Explaination
The original benchmark
viscous_weno5_sgb_mono
did not specify the monopole support type, so it defaulted to 1. However, support = 1 is not valid for 3D simulations and triggered none of the if-statements in thef_delta
function within the monopole module, resulting inf_delta
being undefined. I'm not entirely sure why it only started failing on Frontier and Phoenix in my PR #495, but it's probably due to the floating-point numbers being checked differently.The modified benchmark file should simulate what it intends to simulate, with the computational domain and parameters remaining the same. The only changes are adding
Mono(1)%support' : 4
and a rotation of the domain to align the z-axis with the requirements of monopole support 4.Now, I've made monopole support mandatory through checks (along with other monopole parameters) to prevent this from happening again. I've also added test cases for monopoles as requested (support 6 for cylindrical coordinates cannot be run, so no check is implemented).
Type of change
Scope
How Has This Been Tested?
Test Configuration:
Checklist
./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/simulation
)To make sure the code is performing as expected on GPU devices, I have:
Performance tests are not done as the changes are strictly in the parameter checking and initialization stages, and only involves assigning values to variables.