Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Examples, Added Examples CI. #664

Merged
merged 100 commits into from
Dec 3, 2024
Merged

Conversation

okBrian
Copy link
Contributor

@okBrian okBrian commented Oct 28, 2024

Description

Reduced Example Test cases and added to CI
Fixed examples
Fixed bugs breaking some of the examples

Currently skips these examples:
["2D_ibm_cfl_dt", "1D_sodHypo", "2D_viscous", "2D_laplace_pressure_jump", "2D_bubbly_steady_shock", "2D_advection", "2D_hardcodied_ic", "2D_ibm_multiphase"]

Fixes #474

To-do

  • Add GH issue listing skipped example cases in CI, what it means for them to be currently "broken", and what you remember about why they are broken (NaN, tolerance, etc.). Include some possible paths to success (grid size? time step size? etc.)

Type of change

  • New feature (non-breaking change which adds functionality)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

  • Github CI
  • Locally on a Ubuntu VM with intel compilers, and my compiler with GCC 14.2

Test Configuration:

  • What computers and compilers did you use to test this:

Checklist

  • I have added comments for the new code
  • I ran ./mfc.sh format before committing my code
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

@sbryngelson
Copy link
Member

Can be merged once CI passes + merge conflicts resolved.

@sbryngelson sbryngelson added enhancement New feature or request continuous-integration Continuous integration (CI) labels Nov 13, 2024
@sbryngelson sbryngelson merged commit ca36ffb into MFlowCode:master Dec 3, 2024
27 checks passed
@sbryngelson
Copy link
Member

I opened a companion issue to fix the broken CI cases: #751 @okBrian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Add examples/ into CI
3 participants