Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in adaptive time-stepping #667

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

wilfonba
Copy link
Contributor

@wilfonba wilfonba commented Oct 31, 2024

Description

Fixes a bug where the adaptive time step small dt check failed to trigger due to variable scope.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Ran a case that triggers this error

@wilfonba wilfonba requested a review from sbryngelson as a code owner October 31, 2024 19:33
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (563bc7f) to head (815e51c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_start_up.fpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   54.54%   54.53%   -0.01%     
==========================================
  Files          61       61              
  Lines       13800    13802       +2     
  Branches     1727     1727              
==========================================
  Hits         7527     7527              
- Misses       5817     5819       +2     
  Partials      456      456              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit 44bce70 into MFlowCode:master Nov 1, 2024
21 of 23 checks passed
@wilfonba wilfonba deleted the dtBugFix branch November 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants