Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Changes on #544 for Rectangle Patches #685

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

haochey
Copy link
Contributor

@haochey haochey commented Nov 5, 2024

Description

The changes on the rectangle patches are added mistakenly, as confirmed by @henryleberre.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

This resolve the NaN issue when more than one IB patches are initialized in the pre_process.

Test Configuration:

  • What computers and compilers did you use to test this: MacOS and GCC

Checklist

  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

The changes on the rectangle patches are added mistakenly.
@haochey haochey requested a review from sbryngelson as a code owner November 5, 2024 16:21
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.90%. Comparing base (e2ceaf5) to head (cb8d647).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   42.89%   42.90%   +0.01%     
==========================================
  Files          61       61              
  Lines       16070    16066       -4     
  Branches     1799     1798       -1     
==========================================
  Hits         6893     6893              
+ Misses       8191     8187       -4     
  Partials      986      986              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit e4cf90b into MFlowCode:master Nov 6, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants