Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TWO_PASS_IPO if NVHPC Version < 23.11 #686

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

okBrian
Copy link
Contributor

@okBrian okBrian commented Nov 5, 2024

Description

Disables IPO Two Pass for NVHPC compilers version < 23.11

Fixes #613

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

  • Tested on Rogue Galleries Violet with nvhpc-nompi/23.7 then nvhpc-nompi/23.11

Test Configuration:
Rogue Galleries, Violet, nvhpc-nompi/23.7 & nvhpc-nompi/23.11

Checklist

  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line coun

@okBrian okBrian changed the title Disable IPO if NVHPC Version < 23.11 Disable TWO_PASS_IPO if NVHPC Version < 23.11 Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.89%. Comparing base (e2ceaf5) to head (b64b2a3).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   42.89%   42.89%           
=======================================
  Files          61       61           
  Lines       16070    16070           
  Branches     1799     1799           
=======================================
  Hits         6893     6893           
  Misses       8191     8191           
  Partials      986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit 6fe815d into MFlowCode:master Nov 6, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unclear if two-pass compilation on NV GPU supports old versions of NVHPC
2 participants