Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cray workaround removal #700

Merged
merged 16 commits into from
Nov 8, 2024

Address PR reivew comments

ab4a3c4
Select commit
Loading
Failed to load commit list.
Merged

Cray workaround removal #700

Address PR reivew comments
ab4a3c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2024 in 0s

42.84% (target 1.00%)

View this Pull Request on Codecov

42.84% (target 1.00%)

Details

Codecov Report

Attention: Patch coverage is 29.29293% with 70 lines in your changes missing coverage. Please review.

Project coverage is 42.84%. Comparing base (39e410a) to head (ab4a3c4).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_cbc.fpp 3.12% 62 Missing ⚠️
src/common/m_phase_change.fpp 0.00% 3 Missing ⚠️
src/common/m_variables_conversion.fpp 75.00% 1 Missing and 1 partial ⚠️
src/simulation/m_data_output.fpp 83.33% 0 Missing and 1 partial ⚠️
src/simulation/m_rhs.fpp 0.00% 1 Missing ⚠️
src/simulation/m_riemann_solvers.fpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   43.04%   42.84%   -0.20%     
==========================================
  Files          61       61              
  Lines       16062    16281     +219     
  Branches     1798     1891      +93     
==========================================
+ Hits         6914     6976      +62     
- Misses       8158     8260     +102     
- Partials      990     1045      +55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov