-
Notifications
You must be signed in to change notification settings - Fork 109
Add Broadband Acoustic Src #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
==========================================
- Coverage 42.97% 42.95% -0.03%
==========================================
Files 61 61
Lines 16315 16340 +25
Branches 1882 1883 +1
==========================================
+ Hits 7012 7019 +7
- Misses 8260 8279 +19
+ Partials 1043 1042 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address comments and add full documentation :D
Needs test suite cases in 1D and 2D at least |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple more questions/changes
Description
Broadband source creates acoustic wave with similar amplitude across a wide range of frequency. It will be useful for simulations for noise reduction.
Type of change
Scope
How Has This Been Tested?
Using a probe to record the pressure time history of the source.
Test Configuration:
import json, math
Configuring case dictionary
print(json.dumps({
# Logistics ================================================================
'run_time_info' : 'T',
# ==========================================================================
}))
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/simulation
)To make sure the code is performing as expected on GPU devices, I have:
nvtx
ranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys
, and have attached the output file (.nsys-rep
) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --omniperf
, and have attached the output file and plain text results to this PR.