Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chemistry advection fluxes #752

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

henryleberre
Copy link
Member

Description

Fixes the chemistry advection fluxes. HLL & HLLC are now correct in >2D.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@henryleberre henryleberre added the bug Something isn't working or doesn't seem right label Dec 8, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.86%. Comparing base (ca36ffb) to head (cd68c0a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/common/m_variables_conversion.fpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   45.87%   45.86%   -0.01%     
==========================================
  Files          61       61              
  Lines       16915    16898      -17     
  Branches     1962     1961       -1     
==========================================
- Hits         7759     7751       -8     
+ Misses       7942     7934       -8     
+ Partials     1214     1213       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

@henryleberre can you comment on the status of this PR? ready to go or?

@sbryngelson sbryngelson merged commit ffce00e into MFlowCode:master Dec 13, 2024
27 checks passed
@sbryngelson sbryngelson deleted the chem-adv-fixes branch December 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or doesn't seem right
Development

Successfully merging this pull request may close these issues.

2 participants