-
Notifications
You must be signed in to change notification settings - Fork 4
fixed some linting errors #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to first update your "main" branch locally with the changes that I committed yesterday first (which you reviewed for "Pull Request"). Manezha has to approve and merge it first. Then you pull the fresh "communication" file onto your computer, make the changes and then push to your branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can i approve this changes, I believe they fix the markdown errors
Hi @olumide-AI , Thanks for asking. You can approve it by clicking on the add to review button at the top right corner in the page, and then finish your review by approving it from the list showed in the second screenshot. You can approve it directly or by adding comments. Some colleagues have posted videos on this matter in CD slack group, I'll tag you if I find it. Please let me know if you are still unable to approve it, I'm happy to help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed after merging the conflicts
Fixed some linting errors i could find on the communication documentation