Skip to content

fixed some linting errors #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

olumide-AI
Copy link

Fixed some linting errors i could find on the communication documentation

@olumide-AI olumide-AI added the documentation Improvements or additions to documentation label Dec 27, 2024
@olumide-AI olumide-AI self-assigned this Dec 27, 2024
Copy link

@suhrobmuboraksho suhrobmuboraksho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@suhrobmuboraksho suhrobmuboraksho self-requested a review December 28, 2024 01:08
Copy link

@suhrobmuboraksho suhrobmuboraksho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to first update your "main" branch locally with the changes that I committed yesterday first (which you reviewed for "Pull Request"). Manezha has to approve and merge it first. Then you pull the fresh "communication" file onto your computer, make the changes and then push to your branch.

Copy link
Author

@olumide-AI olumide-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can i approve this changes, I believe they fix the markdown errors

@Khadijaramlawi
Copy link

Hi @olumide-AI , Thanks for asking. You can approve it by clicking on the add to review button at the top right corner in the page, and then finish your review by approving it from the list showed in the second screenshot. You can approve it directly or by adding comments. Some colleagues have posted videos on this matter in CD slack group, I'll tag you if I find it. Please let me know if you are still unable to approve it, I'm happy to help
Screenshot 2024-12-28 at 11 32 56 AM
Screenshot 2024-12-28 at 11 32 32 AM

Copy link

@suhrobmuboraksho suhrobmuboraksho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed after merging the conflicts

@yuri-spizhovyi-mit yuri-spizhovyi-mit merged commit 6345f93 into main Dec 29, 2024
8 of 10 checks passed
@Manezhahm Manezhahm added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 30, 2024
@Manezhahm Manezhahm linked an issue Dec 30, 2024 that may be closed by this pull request
@suhrobmuboraksho suhrobmuboraksho deleted the communication-olumide-kolawole branch January 7, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

a demo issue
5 participants