Open
Conversation
Collaborator
|
The dotfile default makes sense for this tool's use case. One small ask: could you add a skipped = [f for f in files if any(part.startswith(".") for part in f.parts)]
if skipped:
logger.debug("Skipping %d file(s) in hidden directories", len(skipped))
files = [f for f in files if f not in skipped] with that it would be great! |
rafiattrach
requested changes
Apr 1, 2026
Collaborator
rafiattrach
left a comment
There was a problem hiding this comment.
Please see comment above, thanks!
f8c5f70 to
1502d11
Compare
Collaborator
Author
|
added logger to capture skipped files and also a new test case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skips parsing directories like .git, .dvc, .cache, .venv, etc.