Skip to content

fix parsing hidden directories#60

Open
ogmanojdev wants to merge 2 commits intoMIT-LCP:mainfrom
ogmanojdev:fix/skiphiddendirs
Open

fix parsing hidden directories#60
ogmanojdev wants to merge 2 commits intoMIT-LCP:mainfrom
ogmanojdev:fix/skiphiddendirs

Conversation

@ogmanojdev
Copy link
Copy Markdown
Collaborator

skips parsing directories like .git, .dvc, .cache, .venv, etc.

@rafiattrach
Copy link
Copy Markdown
Collaborator

The dotfile default makes sense for this tool's use case. One small ask: could you add a logger.debug when files are skipped due to hidden paths? Silent filtering is hard to debug if someone's data happens to live under a dotfile directory. Something like:

skipped = [f for f in files if any(part.startswith(".") for part in f.parts)]                                                                                              
if skipped:     
    logger.debug("Skipping %d file(s) in hidden directories", len(skipped))
files = [f for f in files if f not in skipped]                                                                                                                             

with that it would be great!

Copy link
Copy Markdown
Collaborator

@rafiattrach rafiattrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment above, thanks!

@ogmanojdev ogmanojdev force-pushed the fix/skiphiddendirs branch from f8c5f70 to 1502d11 Compare April 2, 2026 09:27
@ogmanojdev
Copy link
Copy Markdown
Collaborator Author

added logger to capture skipped files and also a new test case

@ogmanojdev ogmanojdev requested a review from rafiattrach April 2, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants