New Feature: Feasibility Polishing #25
Open
+725
−79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an optional feasibility-polishing phase that can be run after the normal PDHG solve.
What is new
--feasibility_polishing# enable the phase--eps_feas_polish_relative <tol># relative tolerance (default 1e-6)Two independent polishing loops
– Primal polish: solves a feasibility primal problem.
– Dual polish: solves an unconstrained dual feasibility problem.
If both primal polish and dual polish success, polished solutions will be saved.
Implementation details
primal_feas_polish_state_tanddual_feas_polish_state_tthat reuse the GPU buffers already allocated for the main solver.compute_primal_residual_kernel,compute_dual_residual_kernel,zero_finite_value_vectors_kerneland helper functionscompute_primal_residual,compute_dual_residual.TERMINATION_REASON_FEAS_POLISH_SUCCESS.README