Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom skip link(s) #60

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Allow custom skip link(s) #60

merged 1 commit into from
Mar 26, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Mar 26, 2024

Why these changes are being introduced:

TIMDEX UI requires multiple skip links, and other applications may benefit from being able to change the href or text of the skip link.

Relevant ticket(s):

How this addresses that need:

This moves the skip link to a partial, layouts/_skip_links.html.erb, so applications using this gem can customize it if needed.

Side effects of this change:

Any CSS changes (e.g., if we need to add a class selector for multiple skip links).

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

TIMDEX UI requires multiple skip links, and other applications
may benefit from being able to change the href or text of the
skip link.

Relevant ticket(s):

* [GDT-161](https://mitlibraries.atlassian.net/browse/GDT-161)

How this addresses that need:

This moves the skip link to a partial, `layouts/_skip_links.html.erb`,
so applications using this gem can customize it if needed.

Side effects of this change:

Any CSS changes (e.g., if we need to add a class selector for multiple
skip links).
@JPrevost JPrevost self-assigned this Mar 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8439974376

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.372%

Totals Coverage Status
Change from base Build 7849763332: 0.0%
Covered Lines: 38
Relevant Lines: 43

💛 - Coveralls

@jazairi jazairi merged commit ba5bdc9 into main Mar 26, 2024
2 checks passed
@jazairi jazairi deleted the gdt-161-skip-links branch March 26, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants