Skip to content

Adds ADR for semantic query processing flow#947

Merged
JPrevost merged 1 commit intomainfrom
use-424-semantic-query-builder-plan
Mar 3, 2026
Merged

Adds ADR for semantic query processing flow#947
JPrevost merged 1 commit intomainfrom
use-424-semantic-query-builder-plan

Conversation

@JPrevost
Copy link
Member

Why are these changes being introduced:

  • Documention in the repository of the decision to implement a semantic query processing flow in the application, and the rationale for doing so will help us remember in the future why we made this decision.

Relevant ticket(s):

How does this address that need:

  • Provides context, the decision, and consequences for this decision.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to timdex-api-p-use-424-se-u3s57f February 27, 2026 19:58 Inactive
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the decision, both stated directly (doc-only, separate service) and implicitly (possibility of moving to AWS OpenSearch Serverless). Bi-encoding does have some advantages, but the promise of higher efficiency and less latency far outweighs them in my opinion.

I also feel more comfortable processing semantic queries outside of OpenSearch. The additional maintenance is worth considering, but hopefully the tool will be simple enough that it won't be too onerous.

Thanks for writing this up. 👍

Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the decisions being described here. I'm curious about the inability to deploy ML models within a serverless context (although I've not looked into that at all, and it makes a sort of sense) - but like Isra mentioned, I kind of like having more control over more parts of this platform.

Certainly as an initial position, what's described here makes sense. If it turns out we need something different later, our experience will guide our future selves.

Why are these changes being introduced:

* Documention in the repository of the decision to implement a semantic
  query processing flow in the application, and the rationale for doing
  so will help us remember in the future why we made this decision.

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-424

How does this address that need:

* Provides context, the decision, and consequences for this decision.
@JPrevost JPrevost force-pushed the use-424-semantic-query-builder-plan branch from b6368d1 to 682a9a8 Compare March 3, 2026 21:36
@JPrevost JPrevost temporarily deployed to timdex-api-p-use-424-se-u3s57f March 3, 2026 21:36 Inactive
@JPrevost JPrevost merged commit 0e4cfa8 into main Mar 3, 2026
3 checks passed
@JPrevost JPrevost deleted the use-424-semantic-query-builder-plan branch March 3, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants