Skip to content

feat(chat): 채팅방 채팅 메세지 전달 로직 디버깅 (#78)#161

Merged
jaehyeok-code merged 1 commit intodevfrom
feat/#78
Aug 25, 2025
Merged

feat(chat): 채팅방 채팅 메세지 전달 로직 디버깅 (#78)#161
jaehyeok-code merged 1 commit intodevfrom
feat/#78

Conversation

@jaehyeok-code
Copy link
Contributor

@jaehyeok-code jaehyeok-code commented Aug 25, 2025

Summary by CodeRabbit

  • Refactor
    • WebSocket 브로커 설정을 간소화하여 기본 하트비트와 스케줄러 동작을 사용하도록 조정했습니다.
    • 커스텀 스케줄러·하트비트 값을 제거해 불필요한 리소스 점유를 줄이고 기본 설정과의 일관성을 확보했습니다.
    • 기존 토픽/큐 엔드포인트는 그대로 동작하며, 클라이언트 연결 및 메시징 기능에는 변화가 없습니다.
    • 운영 환경에서의 유지보수 편의성과 안정성을 향상했습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

WebSocket 설정에서 커스텀 ThreadPoolTaskScheduler 및 명시적 하트비트 값을 제거하고, enableSimpleBroker("/topic", "/queue")의 기본 스케줄러/하트비트 동작을 사용하도록 변경했습니다. 공개 메서드 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Change summary
WebSocket 브로커 기본설정 사용
backendProject/src/main/java/likelion/mlb/backendProject/global/configuration/UnifiedWebSocketConfig.java
커스텀 TaskScheduler 생성 및 setTaskScheduler, setHeartbeatValue 제거. simple broker 활성화만 유지하여 기본 스케줄러/하트비트로 동작.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant C as Client
    participant E as STOMP Endpoint
    participant B as SimpleBroker (Spring)

    Note over E,B: 현재 구성: 기본 스케줄러/하트비트 사용

    C->>E: CONNECT
    E->>B: 세션 등록
    B-->>C: CONNECTED (기본 하트비트 파라미터)
    C->>B: SUBSCRIBE /topic, /queue
    C-->>B: SEND (메시지)
    B-->>C: MESSAGE (구독자에게 브로드캐스트)

    Note over B: 하트비트/스케줄링은 Spring 기본값으로 처리
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • hwichoi0317
  • Kim-Jaehyun0328
  • wjkim9
  • roode1017

Poem

깡총, 깡총—코드밭을 달리네 🐇
심장 박동은 기본 박자에 맡기고,
스케줄러는 잠시 휴식 중—쉿!
토픽과 큐로 춤추는 프레임들,
단순한 리듬이 오늘의 트랙.
메시지야, 가볍게 흘러라♪


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f72e003 and 1027ba3.

📒 Files selected for processing (1)
  • backendProject/src/main/java/likelion/mlb/backendProject/global/configuration/UnifiedWebSocketConfig.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/#78

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jaehyeok-code jaehyeok-code merged commit 70bdc60 into dev Aug 25, 2025
1 check was pending
@jaehyeok-code jaehyeok-code deleted the feat/#78 branch August 25, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant