Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sfr): kinematic wave approximation option #1899

Merged

Conversation

jdhughes-usgs
Copy link
Contributor

Checklist of items for pull request

  • Added new test or modified an existing test
  • Ran black on new and modified autotests
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated meson files, makefiles, and Visual Studio project files for new source files
  • Updated definition files
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@jdhughes-usgs jdhughes-usgs marked this pull request as draft June 25, 2024 22:05
@jdhughes-usgs jdhughes-usgs force-pushed the sfr-kinematic-6.6.0.dev0 branch 2 times, most recently from 82896dd to e5775cc Compare June 30, 2024 21:53
@jdhughes-usgs jdhughes-usgs force-pushed the sfr-kinematic-6.6.0.dev0 branch 2 times, most recently from 5903ce9 to d525ca8 Compare July 9, 2024 14:20
@jdhughes-usgs jdhughes-usgs force-pushed the sfr-kinematic-6.6.0.dev0 branch 2 times, most recently from 5afafcf to 79ac096 Compare July 17, 2024 01:07
@jdhughes-usgs jdhughes-usgs marked this pull request as ready for review September 24, 2024 18:59
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to consider. The method looks like it is working as expected, especially based on our offline discussion of the Mahoning Creek example.

doc/ReleaseNotes/develop.tex Outdated Show resolved Hide resolved
src/Model/ModelUtilities/GwfSfrStatic.f90 Outdated Show resolved Hide resolved
@jdhughes-usgs jdhughes-usgs merged commit de9b543 into MODFLOW-USGS:develop Sep 26, 2024
22 checks passed
@jdhughes-usgs jdhughes-usgs deleted the sfr-kinematic-6.6.0.dev0 branch September 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants